-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS: modernize app bundle info #941
Conversation
5e4ac42
to
155bd19
Compare
- updated Info.plist - renamed app icon - added gxw document icon
155bd19
to
402dbc8
Compare
@cmbarton While it is not really testable, as the |
Indeed. These are really outstanding and will make it much easier for Mac users to compile on their own if they so choose. |
I meant, I made a couple of hours ago some changes to grass-conda, that mirrors the changes of this PR. Please try it out. Specifically see if the gxw document icon is displayed. |
Shall this still go into 7.8.4 which is overdue? I suggest to move the milestone otherwise. |
This can safely go to 7.8.4. The files modified by this PR are nowadays not in use anywhere (except the app icon, which I only renamed). Therefore: not much to break! :) |
Will you or shall I merge it and backport? |
I don't think I have the authority to do that, do I? |
- updated Info.plist - renamed app icon - added gxw document icon
Done and done! |
Thank you! |
This updates mac app bundle info:
While not solves #457, this is a step towards it. For the time being, the new Info.plist may be used (patched) by packagers.
Screenshot of the gxw document icon: